FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
44 12 0 0

Files

Class Bugs
net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings 6
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDataComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDateComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDirComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileNameComparator 1
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileSizeComparator 1

net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand

Bug Category Details Line Priority
Found reliance on default encoding in net.sf.jguiraffe.examples.tutorial.createfile.CreateFileCommand.execute(): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 92 High

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.getFileDateFrom() may expose internal representation by returning ViewSettings.fileDateFrom MALICIOUS_CODE EI_EXPOSE_REP 322 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.getFileDateTo() may expose internal representation by returning ViewSettings.fileDateTo MALICIOUS_CODE EI_EXPOSE_REP 332 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.getFileTypes() may expose internal representation by returning ViewSettings.fileTypes MALICIOUS_CODE EI_EXPOSE_REP 282 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.setFileDateFrom(Date) may expose internal representation by storing an externally mutable object into ViewSettings.fileDateFrom MALICIOUS_CODE EI_EXPOSE_REP2 327 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.setFileDateTo(Date) may expose internal representation by storing an externally mutable object into ViewSettings.fileDateTo MALICIOUS_CODE EI_EXPOSE_REP2 337 Medium
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings.setFileTypes(String[]) may expose internal representation by storing an externally mutable object into ViewSettings.fileTypes MALICIOUS_CODE EI_EXPOSE_REP2 287 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDataComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDataComparator.compare(FileData, FileData) negates the return value of java.util.Comparator.compare(Object, Object) BAD_PRACTICE RV_NEGATING_RESULT_OF_COMPARETO 531 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDateComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDateComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 444-449 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDirComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileDirComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 457-490 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileNameComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileNameComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 418-423 Medium

net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileSizeComparator

Bug Category Details Line Priority
net.sf.jguiraffe.examples.tutorial.viewset.ViewSettings$FileSizeComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 431-436 Medium